garydgregory commented on code in PR #437:
URL: https://github.com/apache/commons-compress/pull/437#discussion_r1390265464
##########
src/test/java/org/apache/commons/compress/compressors/lz4/FramedLZ4CompressorRoundtripTest.java:
##########
@@ -104,15 +104,17 @@ private void roundTripTest(final String testFile, final
FramedLZ4CompressorOutpu
@Test
public void test64KMultipleBlocks() throws IOException {
- final ByteArrayOutputStream buffer = new ByteArrayOutputStream();
- final byte[] expected = new byte[98304];
+ ByteArrayOutputStream buffer = new ByteArrayOutputStream();
+ byte[] expected = new byte[98304];
new Random(0).nextBytes(expected);
- try (FramedLZ4CompressorOutputStream compressor = new
FramedLZ4CompressorOutputStream(buffer,
- new
FramedLZ4CompressorOutputStream.Parameters(FramedLZ4CompressorOutputStream.BlockSize.K64,
true, false, false))) {
+ try (FramedLZ4CompressorOutputStream compressor =
+ new FramedLZ4CompressorOutputStream(buffer,
+ new
FramedLZ4CompressorOutputStream.Parameters(FramedLZ4CompressorOutputStream.BlockSize.K64,
true, false, false))) {
compressor.write(expected);
}
try (FramedLZ4CompressorInputStream sis = new
FramedLZ4CompressorInputStream(new ByteArrayInputStream(buffer.toByteArray())))
{
- assertArrayEquals(expected, IOUtils.toByteArray(sis));
+ final byte[] actual = IOUtils.toByteArray(sis);
+ assertArrayEquals(expected, actual);
Review Comment:
Hello @cpreisler
Same question as before:
Why is this method different? Don't change it unless it is required.
Non-required changes make PRs harder and longer to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
