aherbert commented on code in PR #138:
URL: https://github.com/apache/commons-numbers/pull/138#discussion_r1341955302
##########
commons-numbers-core/src/main/java/org/apache/commons/numbers/core/DD.java:
##########
@@ -1924,6 +1924,18 @@ public DD pow(int n) {
return computePow(x, xx, n);
}
+ /** {@inheritDoc} */
+ @Override
+ public boolean isZero() {
+ return equals(0.0, x) && equals(0.0, xx);
Review Comment:
If you rebase on master then you will pick up changed I made to the DD and
FP64 classes to use numerical equivalence for zero, i.e. `-0.0 == 0.0`. It
fixes the usage of the classes as a field according to the field definition of
zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
