garydgregory commented on code in PR #221:
URL: https://github.com/apache/commons-bcel/pull/221#discussion_r1287721741
##########
src/main/java/org/apache/bcel/generic/Type.java:
##########
@@ -365,6 +366,24 @@ public int hashCode() {
return type ^ signature.hashCode();
}
+ static String internalTypeNameToSignature(final String internalTypeName) {
+ if (StringUtils.isEmpty(internalTypeName) ||
StringUtils.equalsAny(internalTypeName, "B", "C", "D", "F", "I", "J", "S",
"Z")) {
+ return internalTypeName;
Review Comment:
Hi all,
I'm looking for clarity when reading the code. A hard coded array of strings
is bad. Having a good name for a constant would help, and SHORT_NAMES is not a
good name when the class is Constants or Consts. Any improvement is
appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
