kinow commented on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-1007768801
@gwlucastrig , @darkma773r I believe this is ready for review again. And I think it is really close to being ready to be merged! :tada: @darkma773r I've removed the `Imaging` public methods that used `ImagingParameter`'s (and `Hashmap`'s before). This reduced the amount of public methods in `Imaging`, and later we can decide whether to add back methods with Parameter factories/builders/mergers/etc, or create builders in each parsers, or improve the parsers' API'... After rebasing, there was a bit of Javadoc errors, probably from recent plug-in versions. Fixed those too, reviewed the code removing unnecessary changes, and finally added the `changes.xml` entry. With this, leaving the 126 modified files for you guys to review :smile: (sorry!) Thanks a lot for the help, Bruno -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
