[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=650478&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650478
]
ASF GitHub Bot logged work on IMAGING-159:
------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Sep/21 10:23
Start Date: 14/Sep/21 10:23
Worklog Time Spent: 10m
Work Description: gwlucastrig commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-919020286
I wonder whether we might be able to use Reflection and move the static
resolveParameters() method into the base class so that it only appears once.
resolveParameters would take a class as an additional argument. That approach
might let us get rid of the two constructors (copy and no-argument) which I
also saw as error-prone.
I'll have to review Java Generics a bit. I almost never use them beyond the
implementations supplied by the Java API. Perhaps in this case they can be
applied to simplify our problem.
Also, I think my idea sort of falls apart because the TiffImagingParameters
does not derive directly from ImagingParameters, but that there is an
intermediate class: TiffImagingParameters extends XmpImagingParameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 650478)
Time Spent: 9h 50m (was: 9h 40m)
> There should be a Parameters class
> ----------------------------------
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
> Affects Versions: 1.0-alpha2
> Reporter: Benedikt Ritter
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
