[ https://issues.apache.org/jira/browse/CLOUDSTACK-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618895#comment-16618895 ]
ASF GitHub Bot commented on CLOUDSTACK-10106: --------------------------------------------- rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware URL: https://github.com/apache/cloudstack/pull/2340#issuecomment-422342539 Test LGTM, but I think the code could be further refactored. I'm unable to find time to do that @nitin-maharana but please see parts of the code where you see several ifs-elses, see how you can improve that and also add more tests? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > GPU/vGPU Support on VMWare > -------------------------- > > Key: CLOUDSTACK-10106 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10106 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, UI, VMware > Affects Versions: 4.11.0.0 > Reporter: Nitin Kumar Maharana > Priority: Major > Labels: VMWARE > Fix For: 4.11.0.0 > > > VMware has added support for NVIDIA GRID K1 and NVIDIA GRID K2 cards as well > as NVIDIA Tesla M6 and Tesla M60 cards. This feature allows CloudStack VMs on > ESXi hosts to use the GPU cards connected to it. Currently, it supports only > NVIDIA GRID K1 and K2 cards for CloudStack VMs. > Feature Specification: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74681765 -- This message was sent by Atlassian JIRA (v7.6.3#76005)