[
https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575526#comment-16575526
]
ASF GitHub Bot commented on CLOUDSTACK-9572:
--------------------------------------------
mike-tutkowski commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary
storage not cleaned up after Stor…
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411923853
The intention of the code is OK. A volume is being moved from one primary
storage to another. If it had any snapshots on the source primary storage, we
do not bring them along to the target primary primary storage. Those
(primary-side) snapshots only helped in understanding the delta of changes that
needed to be copied to secondary storage in the event that another snapshot was
taken. Once we move the volume to its new primary storage, we lose knowledge of
this delta information (which is OK). If the user asks for a new snapshot of
the volume in question, we must take a full snapshot of that volume (but we
should leave a new delta snapshot on this primary storage in case yet another
snapshot is requested later). The intent of the code is to remove the unused
(delta) snapshot that resided on the source primary storage because it is no
longer needed. Its mistake is that it not only removes that delta snapshot, but
it also removes the entirety of the snapshot (both what might have been on
primary storage and what is on secondary storage). This leads to a data loss
for the customer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Snapshot on primary storage not cleaned up after Storage migration
> ------------------------------------------------------------------
>
> Key: CLOUDSTACK-9572
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Storage Controller
> Affects Versions: 4.8.0
> Environment: Xen Server
> Reporter: subhash yedugundla
> Priority: Major
> Fix For: 4.8.1
>
>
> Issue Description
> ===============
> 1. Create an instance on the local storage on any host
> 2. Create a scheduled snapshot of the volume:
> 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local
> storage and is transferring this snapshot to secondary storage. But the
> latest snapshot on local storage will stay there. This is as expected.
> 4. Migrate the instance to another XenServer host with ACS UI and Storage
> Live Migration
> 5. The Snapshot on the old host on local storage will not be cleaned up and
> is staying on local storage. So local storage will fill up with unneeded
> snapshots.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
