[
https://issues.apache.org/jira/browse/CLOUDSTACK-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558191#comment-16558191
]
ASF GitHub Bot commented on CLOUDSTACK-10328:
---------------------------------------------
rafaelweingartner commented on a change in pull request #2773:
CLOUDSTACK-10328: Add Secondary IPv6 address through API
URL: https://github.com/apache/cloudstack/pull/2773#discussion_r205415478
##########
File path: api/src/main/java/com/cloud/network/NetworkService.java
##########
@@ -189,12 +181,16 @@ Network createPrivateNetwork(String networkName, String
displayText, long physic
String netmask, long networkOwnerId, Long vpcId, Boolean sourceNat,
Long networkOfferingId) throws ResourceAllocationException,
ConcurrentOperationException,
InsufficientCapacityException;
- /* Requests an IP address for the guest nic */
- NicSecondaryIp allocateSecondaryGuestIP(long nicId, String ipaddress)
throws InsufficientAddressCapacityException;
+ /**
+ * Requests an IP address for the guest nic
+ */
+ NicSecondaryIp allocateSecondaryGuestIP(long nicId, IpAddresses
requestedIpPair) throws InsufficientAddressCapacityException;
boolean releaseSecondaryIpFromNic(long ipAddressId);
- /* lists the nic informaton */
+ /**
+ * lists the nic informaton
Review comment:
NIC instead of nic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Secondary IPv6 address through API
> --------------------------------------
>
> Key: CLOUDSTACK-10328
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10328
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Gabriel Beims Bräscher
> Assignee: Gabriel Beims Bräscher
> Priority: Critical
>
> Currently, we have IPv6 support in Basic Networking. However, CloudStack does
> not support Multiple IPv6 addresses. This was partially implemented with this
> Pull Request: https://github.com/apache/cloudstack/pull/2028
> The addIpToNic command only supports IPv4:
> https://cloudstack.apache.org/api/apidocs-4.11/apis/addIpToNic.html
> Features:
> - Add IPv6 address alias
> - Check if this IPv6 address is in the configured subnet for that POD/VLAN
> - Update the security group
> The admin will manually add the address to the Instance but the Security
> Grouping should allow it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
