[
https://issues.apache.org/jira/browse/CLOUDSTACK-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462562#comment-16462562
]
ASF GitHub Bot commented on CLOUDSTACK-10344:
---------------------------------------------
rafaelweingartner commented on issue #2511: [CLOUDSTACK-10344] bug when moving
ACL rules (change order with drag and drop)
URL: https://github.com/apache/cloudstack/pull/2511#issuecomment-386326837
Ok, I see what you did there.
Our goal was not to tackle concurrency problems with that new API method. We
have not had these problems so far. The idea was only to fix the drag and drop
sorting/limitations. I can put this in my backlog, and look for a way to tackle
it as well. However, I would prefer a new method to maintain backward
compatibility of that “update” method.
BTW: can I open a transaction in the service (manager) layer? I really do
not like the idea of putting logic in DAOs. If we were using spring to manage
DAOs and transaction we would have `@Transactional` annotation. I see that in
ACS some parts of the code use `@DB`, will it open a transaction for methods
annotated with it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sometimes a bug happens when moving ACL rules (changing their order with drag
> and drop)
> ----------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10344
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10344
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rafael Weingärtner
> Assignee: Rafael Weingärtner
> Priority: Major
> Fix For: 4.12
>
>
> An error is happening in certain conditions, such as when you have only 2 ACL
> rules and you move the last one to the top. There are other conditions, for
> instance, when moving ACLs that are in a sequence of numbers without gaps.
> Example, rules:
> number | rule
> 1 - rule A
> 2 - rule D
> 3 - rule B
> 4 - rule C
> 5 - rule E
> It is not possible to move "rule C" in position 2, 1, and 3.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
