[
https://issues.apache.org/jira/browse/CLOUDSTACK-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457546#comment-16457546
]
ASF GitHub Bot commented on CLOUDSTACK-10360:
---------------------------------------------
rafaelweingartner commented on issue #2598: CLOUDSTACK-10360: Change the method
name.
URL: https://github.com/apache/cloudstack/pull/2598#issuecomment-385167494
I would say that Travis and Jenkins validation are enough for this kind of
PR. Of course, we still need reviews.
@BruceKuiLiu your initiative is good. I have seen @DaanHoogland comments in
your PRs, and he has some good points. Please, do not take them personally. It
is natural to have different opinion/views and they are essential to create
discussion and really achieve improvements and code quality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method name
> ------------------------
>
> Key: CLOUDSTACK-10360
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10360
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: KuiLIU
> Priority: Major
>
> The following method is named as "scoped" that seems to whether the variable
> config is scoped in _scopedStorages or not.
> Actually, the method tries to find a storage of which scope equals to the
> scope of config.
> So that, the method name "findStorage" should be more clear than "scoped".
> {code:java}
> public ScopedConfigStorage scoped(ConfigKey<?> config) {
> for (ScopedConfigStorage storage : _scopedStorages) {
> if (storage.getScope() == config.scope()) {
> return storage;
> }
> }
> throw new CloudRuntimeException("Unable to find config storage for
> this scope: " + config.scope() + " for " + config.key());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
