[
https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436918#comment-16436918
]
ASF GitHub Bot commented on CLOUDSTACK-9114:
--------------------------------------------
nitin-maharana commented on a change in pull request #2508: CLOUDSTACK-9114:
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r181297798
##########
File path: ui/scripts/network.js
##########
@@ -1100,11 +1100,23 @@
});
args.$form.find('.form-item[rel=cleanup]').find('input').attr('checked',
'checked'); //checked
args.$form.find('.form-item[rel=cleanup]').css('display', 'inline-block');
//shown
+
args.$form.find('.form-item[rel=makeredundant]').find('input').attr('checked',
'checked'); //checked
+
args.$form.find('.form-item[rel=makeredundant]').css('display',
'inline-block'); //shown
+
+ if
(Boolean(args.context.networks[0].redundantrouter)) {
Review comment:
@rhtyd, When we say redundant networks, that means it already contains the
new upgraded VR(after Blue-Green deployment), we created after a restart? If
that is the case, I think it would be great, if we give a different name
instead of redundant. Because there is a chance we will misinterpret as RVR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> restartnetwork with cleanup should not update/restart both routers at once
> --------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9114
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Wei Zhou
> Assignee: Wei Zhou
> Priority: Major
>
> for now, restartnetwork with cleanup will stop both RVRs at first, then start
> two new RVRs.
> to reduce the downtime of network, we'd better restart the RVRs one by one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
