Stephan Seitz created CLOUDSTACK-10350: ------------------------------------------
Summary: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" Key: CLOUDSTACK-10350 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10350 Project: CloudStack Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Components: Network Devices Affects Versions: 4.11.0.0 Reporter: Stephan Seitz Attachments: cloudstack-4.11.0-stephans-duplicate-nicaddress-fix.diff {color:#4c4c4c}After upgrading a working 4.9.2 setup to 4.11.0.0 we've noticed that we're unable to add a NIC (shared network) to a running VM via GUI.{color} {color:#4c4c4c}The Error is "A NIC with this MAC address exits for network: (uuid of the current (other NIC) network)"{color} {color:#4c4c4c}Using cloudmonkey and giving a self-computed MAC-address does not rise the error and works as expected.{color} {color:#4c4c4c}After digging into the code, I think I've found the problem, but am too bad in java to provide a sustainable fix.{color} {color:#4c4c4c}I've attached a patch which obviously (with own manual tests) fixes that issue by simply commenting out the respective codeblock.{color} {color:#4c4c4c}As far as I dug into the code, the third parameter of NicProfile is handled by {color} {color:#4c4c4c}NetUtils.long2Mac(NetUtils.createSequenceBasedMacAddress(ipVO.getMacAddress(), NetworkModel.MACIdentifier.value()){color} {color:#4c4c4c}inside{color} {color:#4c4c4c}NicProfileHelperImpl.java{color} {color:#4c4c4c}I assume createSequenceBasedMacAddress can handle null as MAC, but doesn't get called at all if {color} {color:#4c4c4c}_nicDao.findByNetworkIdAndMacAddress(networkId, macAddress) results != null if macAddress is null.{color} -- This message was sent by Atlassian JIRA (v7.6.3#76005)