[
https://issues.apache.org/jira/browse/CLOUDSTACK-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417121#comment-16417121
]
ASF GitHub Bot commented on CLOUDSTACK-10334:
---------------------------------------------
rafaelweingartner closed pull request #2510: CLOUDSTACK-10334: Fix inadequate
information for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
b/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
index feefaabc551..f030209c9a5 100644
--- a/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
+++ b/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
@@ -258,13 +258,11 @@ public void processParameters(final BaseCmd cmd, final
Map params) {
}
} catch (final IllegalArgumentException e) {
- s_logger.error("Error initializing command " +
cmd.getCommandName() + ", field " + field.getName() + " is not accessible.");
throw new CloudRuntimeException("Internal error initializing
parameters for command " + cmd.getCommandName() + " [field " + field.getName() +
- " is not accessible]");
+ " is not accessible]", e);
} catch (final IllegalAccessException e) {
- s_logger.error("Error initializing command " +
cmd.getCommandName() + ", field " + field.getName() + " is not accessible.");
throw new CloudRuntimeException("Internal error initializing
parameters for command " + cmd.getCommandName() + " [field " + field.getName() +
- " is not accessible]");
+ " is not accessible]", e);
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inadequate information for handling catch clauses
> -------------------------------------------------
>
> Key: CLOUDSTACK-10334
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10334
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Zhenhao Li
> Priority: Major
> Labels: easyfix
>
> Their are some situations that different exception types are caught, but the
> handling of those exceptions can not show the differences of those types.
> Here are the code snippets we found which have this problem:
> *cloudstack/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java*
> [https://github.com/apache/cloudstack/blob/893a88d225276e45f12f9490e6af2c94a81c2965/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java]
> At Line *261* and Line *265.* We can see that two exception types are caught,
> but the logging statements here can not show the exception type at all.
> Also they threw new exceptions after the logs, but the throw statements in
> these two catch clauses are identical, which are not distinguishable.
> It may cause confusions to the person who is reading the log, the person can
> not know what exception happened here and can not distinguish logs generated
> by these two statements.
> Maybe adding stack trace information to these two logging statements and
> change the log message to handle specific situations is a simple way to
> improve it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
