[ https://issues.apache.org/jira/browse/CLOUDSTACK-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411691#comment-16411691 ]
ASF GitHub Bot commented on CLOUDSTACK-10271: --------------------------------------------- DaanHoogland closed pull request #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added URL: https://github.com/apache/cloudstack/pull/2446 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/pom.xml b/pom.xml index b1ff1021af1..274d705be28 100644 --- a/pom.xml +++ b/pom.xml @@ -123,6 +123,8 @@ <cs.wiremock.version>2.11.0</cs.wiremock.version> <cs.jetty.version>9.4.8.v20171121</cs.jetty.version> <cs.jetty-maven-plugin.version>9.2.22.v20170606</cs.jetty-maven-plugin.version> + <cs.owasp.esapi.version>2.1.0.1</cs.owasp.esapi.version> + <cs.owasp.dependency-checker.version>3.1.1</cs.owasp.dependency-checker.version> </properties> <distributionManagement> @@ -370,7 +372,7 @@ <dependency> <groupId>org.owasp.esapi</groupId> <artifactId>esapi</artifactId> - <version>2.1.0.1</version> + <version>${cs.owasp.esapi.version}</version> </dependency> <dependency> <groupId>org.eclipse.persistence</groupId> @@ -569,6 +571,22 @@ <build> <defaultGoal>install</defaultGoal> <plugins> + <plugin> + <groupId>org.owasp</groupId> + <artifactId>dependency-check-maven</artifactId> + <version>${cs.owasp.dependency-checker.version}</version> + <configuration> + <skipProvidedScope>true</skipProvidedScope> + <skipRuntimeScope>true</skipRuntimeScope> + </configuration> + <executions> + <execution> + <goals> + <goal>check</goal> + </goals> + </execution> + </executions> + </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-checkstyle-plugin</artifactId> @@ -1045,6 +1063,18 @@ </build> <reporting> <plugins> + <plugin> + <groupId>org.owasp</groupId> + <artifactId>dependency-check-maven</artifactId> + <version>${cs.owasp.dependency-checker.version}</version> + <reportSets> + <reportSet> + <reports> + <report>aggregate</report> + </reports> + </reportSet> + </reportSets> + </plugin> <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>findbugs-maven-plugin</artifactId> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > detect vulnerabilities in depndencies > ------------------------------------- > > Key: CLOUDSTACK-10271 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10271 > Project: CloudStack > Issue Type: Wish > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Daan Hoogland > Assignee: Daan Hoogland > Priority: Major > > As a developer I want to know whether and what dependencies I am using that > might harm my users. For this we need to add the owasp dependency checker to > the maven build. It will require more then just this but it is a good first > step. -- This message was sent by Atlassian JIRA (v7.6.3#76005)