[
https://issues.apache.org/jira/browse/CLOUDSTACK-10332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410812#comment-16410812
]
ASF GitHub Bot commented on CLOUDSTACK-10332:
---------------------------------------------
blueorangutan commented on issue #2496: [CLOUDSTACK-10332] Users are not able
to change/edit the protocol of an ACL rule
URL: https://github.com/apache/cloudstack/pull/2496#issuecomment-375545689
<b>Trillian test result (tid-2404)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32457 seconds
Marvin logs:
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2496-t2404-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 204.34 |
test_privategw_acl.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 497.44 |
test_vpc_redundant.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.44 |
test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Users are not able to change/edit the protocol of an ACL rule
> --------------------------------------------------------------
>
> Key: CLOUDSTACK-10332
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10332
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rafael Weingärtner
> Assignee: Rafael Weingärtner
> Priority: Major
> Fix For: 4.12
>
>
> Users should be able to edit an ACL rule completely. Therefore, they must be
> able to change the protocol type and others configs of an ACL rules.
> Right now users are not able to execute the following.
> * Create an ACL for ICMP
> * Click on edit and change the protocol to TCP
> * An error will happen when saving the rule.
> Users should be able to execute the protocol changes without problem.
> In addition, it is not just the protocol that users are not able to change.
> For instance, after defining ports, or reason/description for the rule, users
> are not able to set those values back to null. The same happens for ICMP code
> and type.
> We will introduce a new parameter called "partialUpdate", which will have its
> default value as true to maintain backward compatibility. When this parameter
> is set to false, we will consider only the parameters sent, and not the
> parameters we already have in the database to change and validate the ACL
> rule data. This allows us to update parameters already set back to null, and
> to completely change an ACL rule.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
