[
https://issues.apache.org/jira/browse/CLOUDSTACK-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380559#comment-16380559
]
ASF GitHub Bot commented on CLOUDSTACK-10268:
---------------------------------------------
rhtyd commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and
enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#discussion_r171297624
##########
File path: tools/build/setnextversion.sh
##########
@@ -16,60 +16,125 @@
# specific language governing permissions and limitations
# under the License.
-version='TESTBUILD'
-sourcedir=~/cloudstack/
-branch='master'
+set -e
-usage(){
- echo "usage: $0 -v version [-b branch] [-s source dir] [-h]"
- echo " -v sets the version"
- echo " -b sets the branch (defaults to 'master')"
- echo " -s sets the source directory (defaults to $sourcedir)"
- echo " -h"
+usage() {
+ cat << USAGE
+Usage: setnextversion.sh --version string [OPTIONS]...
+Set the next version of CloudStack in the POMs.
+
+Mandatory arguments:
+ -v, --version string Set the next version to be applied
+
+Optional arguments:
+ -b, --branch string Set the branch to update the
version into (default "master")
+ -s, --sourcedir string Set the source directory to clone
repo into (default "$sourcedir")
+ -n, --no-commit Apply only the version change and
don't git commit them (default "false")
Review comment:
@khos2ow @rafaelweingartner please update the wiki as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix and enhance package script
> ------------------------------
>
> Key: CLOUDSTACK-10268
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10268
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Packaging
> Reporter: Khosrow Moossavi
> Priority: Minor
> Fix For: 4.12.0.0
>
>
> * new flag `-T, --use-timestamp` to use `timestamp` when POM version contains
> SNAPSHOT
> ** in the final artifacts (jar) name
> ** in the final package (rpm, deb) name
> ** in `/etc/cloudstack-release` file of SystemVMs
> ** in the Management Server > About dialog
> * if there's a "branding" string in the POM version (e.g.
> `x.y.z.a-NAME[-SNAPSHOT]`), the branding name will be used in the final
> generated pacakge name such as following:
> ** `cloudstack-management-x.y.z.a-NAME.NUMBER.el7.centos.x86_64`
> ** `cloudstack-management_x.y.z.a-NAME-NUMBER~xenial_all.deb`
> * branding string can be overriden with newly added `-b, --brand` flag
> * handle the new format version for VR version
> * fix long opts (they were broken)
> * tolerate and show a warning message for unrecognized flags
> * usage help reformat
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
