[ https://issues.apache.org/jira/browse/CLOUDSTACK-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377437#comment-16377437 ]
ASF GitHub Bot commented on CLOUDSTACK-10307: --------------------------------------------- rafaelweingartner commented on issue #2438: [CLOUDSTACK-10307] Remove unused things from HostDaoImpl URL: https://github.com/apache/cloudstack/pull/2438#issuecomment-368620530 @borisstoyanov is this "test_hostha_enable_ha_when_host_in_maintenance" failure a false positive? I have seen this around in some other PRs. In the log file I see the following: `2018-02-26 19:01:11,248 DEBUG [c.c.a.m.AgentManagerImpl] (API-Job-Executor-63:ctx-62ff4a7f job-2987 ctx-3ead5878) (logid:c3cec415) Can not send command com.cloud.agent.api.MaintainCommand due to Host 2 is not up` It looks like an environment problem. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove unused things from HostDaoImpl > ------------------------------------- > > Key: CLOUDSTACK-10307 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10307 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Rafael Weingärtner > Assignee: Rafael Weingärtner > Priority: Minor > > Remove unnecessary annotation of HostDaoImpl. While removing this annotation > I noticed that one of the methods were not necessary. While removing it, I > found some code in CloudZonesStartupProcessor that was also not used, and > removed it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)