[ https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346446#comment-16346446 ]
ASF GitHub Bot commented on CLOUDSTACK-10225: --------------------------------------------- DaanHoogland commented on issue #2431: CLOUDSTACK-10225: Deprecate StringUtils in favor of Apache Commons URL: https://github.com/apache/cloudstack/pull/2431#issuecomment-361863526 @wido @rafaelweingartner I really think we should empty our StringUtils but maintain it as proxy class. That will reduce our 'surface' to the commons version and facilitate any upgrade. We should apply that principle to any library that we use. We are in big trouble now because this principle is not applied to the json library 'gson'. Also with logging we have such very costly upgrade problems. consequently I think we should move all references to commons string utils to our stringutils and make it the sole dependant on the commons package. </rant> merging now ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Deprecate com.cloud.utils.StringUtils > ------------------------------------- > > Key: CLOUDSTACK-10225 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Wido den Hollander > Priority: Major > > com.cloud.utils.StringUtils contains a lot of methods which can be deprecated > in favor of Apache Commons. > We should try to use Apache Commons where possible and reduce our code > footprint. -- This message was sent by Atlassian JIRA (v7.6.3#76005)