[
https://issues.apache.org/jira/browse/CLOUDSTACK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337999#comment-16337999
]
ASF GitHub Bot commented on CLOUDSTACK-10253:
---------------------------------------------
rhtyd commented on issue #2428: CLOUDSTACK-10253: JSON response for
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-360220812
@marcaurele can you run test_hostha_simulator.py smoketest against simulator
in your local environment and see if you can reproduce and fix the failure? You
can look at Travis log (scroll to the bottom, or see the raw logs), you'll find
error such as following:
```
Traceback (most recent call last):
File
"/home/travis/build/apache/cloudstack/test/integration/smoke/test_hostha_simulator.py",
line 531, in test_ha_verify_fsm_available
self.configureSimulatorHAProviderState(True, True, True, False)
File
"/home/travis/build/apache/cloudstack/test/integration/smoke/test_hostha_simulator.py",
line 164, in configureSimulatorHAProviderState
self.assertEqual(response.success, 'true')
AssertionError: True != 'true'
```
I think we'll need to discuss this on dev@, as this change may potentially
cause regression for API consumers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JSON response returns boolean as string
> ---------------------------------------
>
> Key: CLOUDSTACK-10253
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10253
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Reporter: Marc-Aurèle Brothier
> Assignee: Marc-Aurèle Brothier
> Priority: Minor
>
> On the SuccessResponse for async call, the boolean value is returned as a
> quoted boolean string:
> {noformat}
> {"success": "true"}{noformat}
> instead of a JSON boolean:
> {noformat}
> {"success": true{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
