[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Maximus updated CLOUDSTACK-10255:
---------------------------------------
    Description: 
In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was used.
The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
filtered though, so the file ends up on the host, still containting the 
ReplaceToken.

{noformat:title=KVM Host}You have new mail in /var/spool/mail/root
[root@frank-acs-master ~]# mail
Heirloom Mail version 12.5 7/5/10.  Type ? for help.
"/var/spool/mail/root": 7 messages 7 new
>N  1 Anacron               Thu Jan 18 15:36  17/727   "Anacron job 
>'cron.daily' on frank-acs-master"
 N  2 Anacron               Fri Jan 19 03:50  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  3 Anacron               Sat Jan 20 03:30  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  4 Anacron               Sun Jan 21 03:25  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  5 Anacron               Mon Jan 22 03:39  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  6 Anacron               Tue Jan 23 03:10  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  7 Anacron               Wed Jan 24 03:23  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
& 7
Message  7:
>From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
Return-Path: <root@frank-acs-master.localdomain>
X-Original-To: root
Delivered-To: root@frank-acs-master.localdomain
From: Anacron <root@frank-acs-master.localdomain>
To: root@frank-acs-master.localdomain
Content-Type: text/plain; charset="UTF-8"
Subject: Anacron job 'cron.daily' on frank-acs-master
Date: Wed, 24 Jan 2018 03:23:03 +0000 (UTC)
Status: R

/etc/cron.daily/logrotate:

error: cloudstack-agent:18 lines must begin with a keyword or a filename 
(possibly in double quotes)

& q

[root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
# Licensed to the Apache Software Foundation (ASF) under ..<snip>.. the License.

@AGENTLOG@
/var/log/cloudstack/agent/security_group.log
{
    copytruncate
    daily
    rotate 5
    compress
    missingok
}

{noformat}

  was:
In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was used.
The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
filtered though, so the file ends up on the host, still containting the 
ReplaceToken.

{noformat:title=KVM Host}You have new mail in /var/spool/mail/root
[root@frank-acs-master ~]# mail
Heirloom Mail version 12.5 7/5/10.  Type ? for help.
"/var/spool/mail/root": 7 messages 7 new
>N  1 Anacron               Thu Jan 18 15:36  17/727   "Anacron job 
>'cron.daily' on frank-acs-master"
 N  2 Anacron               Fri Jan 19 03:50  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  3 Anacron               Sat Jan 20 03:30  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  4 Anacron               Sun Jan 21 03:25  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  5 Anacron               Mon Jan 22 03:39  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  6 Anacron               Tue Jan 23 03:10  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
 N  7 Anacron               Wed Jan 24 03:23  17/729   "Anacron job 
'cron.daily' on frank-acs-master"
& 7
Message  7:
>From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
Return-Path: <root@frank-acs-master.localdomain>
X-Original-To: root
Delivered-To: root@frank-acs-master.localdomain
From: Anacron <root@frank-acs-master.localdomain>
To: root@frank-acs-master.localdomain
Content-Type: text/plain; charset="UTF-8"
Subject: Anacron job 'cron.daily' on frank-acs-master
Date: Wed, 24 Jan 2018 03:23:03 +0000 (UTC)
Status: R

/etc/cron.daily/logrotate:

error: cloudstack-agent:18 lines must begin with a keyword or a filename 
(possibly in double quotes)
{noformat}


> cloudstack-agent logrotate is broken
> ------------------------------------
>
>                 Key: CLOUDSTACK-10255
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10255
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: cloudstack-agent
>    Affects Versions: 4.10.0.0, 4.11.0.0, 4.9.3.0
>            Reporter: Frank Maximus
>            Priority: Major
>
> In [PR#2094|https://github.com/apache/cloudstack/pull/2094] logrotate was 
> updated to refer to the new files, and an {{@AGENTLOG@}} ReplaceToken was 
> used.
> The pom file of agent doesn't define {{cloudstack-agent.logrotate}} to be 
> filtered though, so the file ends up on the host, still containting the 
> ReplaceToken.
> {noformat:title=KVM Host}You have new mail in /var/spool/mail/root
> [root@frank-acs-master ~]# mail
> Heirloom Mail version 12.5 7/5/10.  Type ? for help.
> "/var/spool/mail/root": 7 messages 7 new
> >N  1 Anacron               Thu Jan 18 15:36  17/727   "Anacron job 
> >'cron.daily' on frank-acs-master"
>  N  2 Anacron               Fri Jan 19 03:50  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  3 Anacron               Sat Jan 20 03:30  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  4 Anacron               Sun Jan 21 03:25  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  5 Anacron               Mon Jan 22 03:39  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  6 Anacron               Tue Jan 23 03:10  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
>  N  7 Anacron               Wed Jan 24 03:23  17/729   "Anacron job 
> 'cron.daily' on frank-acs-master"
> & 7
> Message  7:
> From root@frank-acs-master.localdomain  Wed Jan 24 03:23:03 2018
> Return-Path: <root@frank-acs-master.localdomain>
> X-Original-To: root
> Delivered-To: root@frank-acs-master.localdomain
> From: Anacron <root@frank-acs-master.localdomain>
> To: root@frank-acs-master.localdomain
> Content-Type: text/plain; charset="UTF-8"
> Subject: Anacron job 'cron.daily' on frank-acs-master
> Date: Wed, 24 Jan 2018 03:23:03 +0000 (UTC)
> Status: R
> /etc/cron.daily/logrotate:
> error: cloudstack-agent:18 lines must begin with a keyword or a filename 
> (possibly in double quotes)
> & q
> [root@frank-acs-master ~]# cat /etc/logrotate.d/cloudstack-agent
> # Licensed to the Apache Software Foundation (ASF) under ..<snip>.. the 
> License.
> @AGENTLOG@
> /var/log/cloudstack/agent/security_group.log
> {
>     copytruncate
>     daily
>     rotate 5
>     compress
>     missingok
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to