[
https://issues.apache.org/jira/browse/CLOUDSTACK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337125#comment-16337125
]
ASF GitHub Bot commented on CLOUDSTACK-10247:
---------------------------------------------
DaanHoogland commented on a change in pull request #2420: CLOUDSTACK-10247: L2
network not shared on projects
URL: https://github.com/apache/cloudstack/pull/2420#discussion_r163479947
##########
File path: server/src/com/cloud/network/NetworkModelImpl.java
##########
@@ -1637,7 +1637,8 @@ public void checkNetworkPermissions(Account owner,
Network network) {
throw new CloudRuntimeException("cannot check permissions on
(Network) <null>");
}
// Perform account permission check
- if (network.getGuestType() != Network.GuestType.Shared ||
(network.getGuestType() == Network.GuestType.Shared && network.getAclType() ==
ACLType.Account)) {
+ if ((network.getGuestType() != Network.GuestType.Shared &&
network.getGuestType() != GuestType.L2) ||
Review comment:
Network.GuestType.Shared is used and then GuestType.L2 directly. please
cleanup the imports and use only one scope for one java class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> L2 network not shared on projects
> ---------------------------------
>
> Key: CLOUDSTACK-10247
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10247
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Nicolas Vazquez
> Assignee: Nicolas Vazquez
> Priority: Major
>
> L2 networks are not shared between projects. When trying to deploy a vm
> assigning a project id, error is logged:
> 2018-01-18 09:04:31,749 INFO [c.c.a.ApiServer]
> (qtp1310540333-17:ctx-7ff91c56 ctx-8c37c46b ctx-d58064ad) (logid:74e86028)
> PermissionDenied: Unable to use network with id=
> 5bee486a-ff20-4db2-b62e-4b4f3485cfff, permission denied on objs: []
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
