[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326078#comment-16326078
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10227:
---------------------------------------------

rhtyd opened a new pull request #2407: CLOUDSTACK-10227: Add delay before 
reverting VM snapshot
URL: https://github.com/apache/cloudstack/pull/2407
 
 
   As discovered and discussed in #2376, adding some delay after stopping
   the VM and reverting VM snapshot passes the
   `test_change_service_offering_for_vm_with_snapshots` test case. The
   suspect here is userVMDao or background vmsync that may not update
   the VM state to PowerOff.
   
   Pinging for review @mike-tutkowski @rafaelweingartner @DaanHoogland and 
others.
   Manually verified with QA:
   ```
   === TestName: test_change_service_offering_for_vm_with_snapshots | Status : 
SUCCESS ===
   ok
   
   Ran 1 test in 501.359s
   OK
   ```
   
   I think since this only changes the test file, it may be accepted only with 
at least code reviews. It's not a blocker, but fixing this smoketest will avoid 
getting incorrect failures.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Stabilization fixes for master/4.11
> -----------------------------------
>
>                 Key: CLOUDSTACK-10227
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10227
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>            Priority: Blocker
>
> List of blocker fixes per the 4.11.0.0 release.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to