[
https://issues.apache.org/jira/browse/CLOUDSTACK-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311476#comment-16311476
]
ASF GitHub Bot commented on CLOUDSTACK-8855:
--------------------------------------------
marcaurele commented on a change in pull request #2380: CLOUDSTACK-8855 Improve
Error Message for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/2380#discussion_r159676070
##########
File path:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
##########
@@ -994,33 +994,28 @@ public Answer easySend(final Long hostId, final Command
cmd) {
}
@Override
- public boolean reconnect(final long hostId) {
+ public void reconnect(final long hostId) throws CloudRuntimeException,
AgentUnavailableException{
HostVO host;
host = _hostDao.findById(hostId);
if (host == null || host.getRemoved() != null) {
- s_logger.warn("Unable to find host " + hostId);
- return false;
+ throw new CloudRuntimeException("Unable to find host " + hostId);
}
if (host.getStatus() == Status.Disconnected) {
- s_logger.info("Host is already disconnected, no work to be done");
- return true;
+ throw new CloudRuntimeException("Host is already disconnected, no
work to be done");
Review comment:
This looks wrong to me, why throwing an exception when nothing has to be
done?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve Error Message for Host Alert State
> ------------------------------------------
>
> Key: CLOUDSTACK-8855
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8855
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.6.0
> Reporter: Bharat Kumar
> Assignee: Bharat Kumar
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
