[ https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311166#comment-16311166 ]
ASF GitHub Bot commented on CLOUDSTACK-10117: --------------------------------------------- marcaurele commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159626258 ########## File path: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java ########## @@ -31,18 +34,27 @@ @Param(description = "port") private int port; + @SerializedName("domain_id") Review comment: @DaanHoogland where do you see mixed convention (on the API)? I can see the `domain_id` when it's refering a database column, but not in the API command/responses so far. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > LDAP mapping on domain level > ---------------------------- > > Key: CLOUDSTACK-10117 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Daan Hoogland > > see FS: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings -- This message was sent by Atlassian JIRA (v6.4.14#64029)