[
https://issues.apache.org/jira/browse/CLOUDSTACK-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255169#comment-16255169
]
ASF GitHub Bot commented on CLOUDSTACK-10129:
---------------------------------------------
rhtyd commented on a change in pull request #2327: CLOUDSTACK-10129: Show
account, network info in VR list view
URL: https://github.com/apache/cloudstack/pull/2327#discussion_r151388752
##########
File path: ui/scripts/system.js
##########
@@ -29,9 +29,19 @@
var mapRouterType = function (index, router) {
var routerType = _l('label.menu.system');
- if (router.projectid) routerType = _l('label.project');
- if (router.vpcid) routerType = _l('label.vpc');
- if ("isredundantrouter" in router && router.isredundantrouter)
routerType = routerType + " (" + router.redundantstate + ")";
+ if (router.projectid) {
+ routerType = _l('label.project');
+ router.account = router.project;
+ }
+
+ if (router.vpcid) {
+ routerType = _l('label.vpc');
+ router.guestnetworkname = router.vpcname;
+ }
+
+ if ("isredundantrouter" in router && router.isredundantrouter) {
Review comment:
Thanks, I get defensive writing code. I guess this is not be necessary here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Show instances attached to a network/VR via navigation from VRs->instances
> --------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10129
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10129
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rohit Yadav
> Assignee: Rohit Yadav
> Priority: Trivial
> Fix For: 4.11.0.0
>
>
> Navigate to Infra->Vrs->select a VR->View instances should show instances
> belonging to guest network id of the VR
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
