[
https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251025#comment-16251025
]
ASF GitHub Bot commented on CLOUDSTACK-9025:
--------------------------------------------
anshul1886 commented on a change in pull request #2315: A comprehensive
solution for #CLOUDSTACK-9025.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r150203016
##########
File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
##########
@@ -1194,4 +1177,26 @@ public HostVO findByIp(final String ipAddress) {
sc.setParameters("type", type);
return listBy(sc);
}
-}
+
+ String sqlFindHostConnectedToSnapshotStoragePoolToExecuteCommand = "select
h.id from snapshots s join volumes v on v.id = s.volume_id "
+ + "join storage_pool pool on pool.id = v.pool_id join cluster c on
pool.cluster_id = c.id join host h on h.cluster_id = c.id "
+ + "where s.id = ? and h.status = 'Up' and h.type = 'Routing' ORDER
by rand() limit 1";
+
+ @Override
+ public HostVO findHostConnectedToSnapshotStoragePoolToExecuteCommand(long
snapshotId) {
Review comment:
This method will not work in scenarios when volume or storage pool
associated to snapshot is deleted. Also there is no need to consider storage
pool as only secondary storage is involved. Any random hypervisor host in zone
will do. Scenarios where storage pool is involved are already handled in core
code and don't go via command delegation route. Also don't use sql queries
instead write queries using Daos.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to deploy VM instance from template if template spin from linked clone
> snapshot
> --------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9025
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: XenServer
> Affects Versions: 4.5.2
> Environment: XenServer 6.5
> Reporter: Anshul Gangwar
> Assignee: Anshul Gangwar
> Priority: Critical
> Fix For: 4.6.0
>
>
> As default, CloudStack create linked clone snapshot for VM instance . When we
> take a snapshot for the VM, and create a template based on such snapshot,
> CloudStack only download incremental VHD as template file, as a result, the
> VM instance fail to deploy as it is incomplete.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
