[
https://issues.apache.org/jira/browse/CLOUDSTACK-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237587#comment-16237587
]
ASF GitHub Bot commented on CLOUDSTACK-10129:
---------------------------------------------
rhtyd commented on a change in pull request #2306: CLOUDSTACK-10129: Allow
navigation from VRs to network, instances, owners etc.
URL: https://github.com/apache/cloudstack/pull/2306#discussion_r148779005
##########
File path: ui/scripts/system.js
##########
@@ -31,6 +31,7 @@
if (router.projectid) routerType = _l('label.project');
if (router.vpcid) routerType = _l('label.vpc');
+ if ("isredundantrouter" in router && router.isredundantrouter)
routerType = routerType + " (" + router.redundantstate + ")";
Review comment:
@nitin-maharana thanks, here I'm not assuming that redundancy of the router
is hard-coded VR being a VPC one only, the if statements are therefore not
nested. In future, if we've redundant isolated/shared network VRs I would want
the redundant state to be reflected (in parenthesis). I think it's alright to
keep as such, unless of course you have a suggestion we can incorporate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Show instances attached to a network/VR via navigation from VRs->instances
> --------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10129
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10129
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rohit Yadav
> Assignee: Rohit Yadav
> Fix For: 4.11.0.0
>
>
> Navigate to Infra->Vrs->select a VR->View instances should show instances
> belonging to guest network id of the VR
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
