[
https://issues.apache.org/jira/browse/CLOUDSTACK-9198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905639#comment-15905639
]
ASF GitHub Bot commented on CLOUDSTACK-9198:
--------------------------------------------
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1278
Great @anshul1886, we seem to start converging.
So, what you call setting context, is the execution of
“org.apache.cloudstack.context.CallContext.getCallingAccount()”, that returns
an account object(the account that is executing the API call). This method
works in a lazy way, which means, it loads the “account” only when it is called
at the first time. And this is what you consider setting the context.
Now let’s get back to what I am questioning you.
Let’s get as an example the method you talked about before
“com.cloud.storage.VolumeApiServiceImpl.uploadVolume(UploadVolumeCmd)”. At line
275, it loads the account object, which is then sent as a parameter to the
method “com.cloud.storage.VolumeApiServiceImpl.validateVolume(Account, long,
Long, String, String, String, Long)”. Then, at line 381 the account object is
used to check if the account executing the command has the proper permissions.
This is exactly my point here. Please check the variables, they are not
being used anywhere. The variables I am mentioning are only passed as
parameters, but the methods that receive them, do not make use of these
variables.
I am starting to think I am not seeing things here; I think we could
benefit from some fresh eyes here. @DaanHoogland, @rhtyd, @nvazquez, could you
lend us your fresh eyes for this PR?
> VR gets created in the disabled POD
> -----------------------------------
>
> Key: CLOUDSTACK-9198
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9198
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Anshul Gangwar
> Assignee: Anshul Gangwar
>
> VR gets created in the disabled POD
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
