[ https://issues.apache.org/jira/browse/CLOUDSTACK-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900803#comment-15900803 ]
ASF GitHub Bot commented on CLOUDSTACK-8672: -------------------------------------------- Github user sowmyakrishn commented on the issue: https://github.com/apache/cloudstack/pull/1859 LGTM based on following tests: Tested with Automated runs for Shared and Dedicated Isolation policies - test_ncc_integration_dedicated.py and test_ncc_integration_shared.py (also part of this PR) and both tests have passed. Result: ==== test_01_shared_first_network (integration.component.test_ncc_integration_shared.TestNccIntegrationShared) ... === TestName: test_01_shared_first_network | Status : SUCCESS === ok test_02_shared_another_network (integration.component.test_ncc_integration_shared.TestNccIntegrationShared) ... === TestName: test_02_shared_another_network | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 2 tests in 472.393s OK test_01_dedicated_first_network (integration.component.test_ncc_integration_dedicated.TestNccIntegrationDedicated) ... === TestName: test_01_dedicated_first_network | Status : SUCCESS === ok test_02_dedicated_another_network (integration.component.test_ncc_integration_dedicated.TestNccIntegrationDedicated) ... === TestName: test_02_dedicated_another_network | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 2 tests in 234.199s OK Further, manual tests were also carried out successfully as per the Test Plan mentioned in https://cwiki.apache.org/confluence/display/CLOUDSTACK/NCC+Integration+with+CloudStack+Test+Plan > NCC Integration with CloudStack > ------------------------------- > > Key: CLOUDSTACK-8672 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8672 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Network Devices > Affects Versions: 4.6.0 > Reporter: Rajesh Battala > Assignee: Rajesh Battala > Priority: Critical > Fix For: Future > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)