[
https://issues.apache.org/jira/browse/CLOUDSTACK-9503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15513561#comment-15513561
]
ASF GitHub Bot commented on CLOUDSTACK-9503:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1678#discussion_r80063605
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -636,7 +637,7 @@ public ExecutionResult executeInVR(final String
routerIP, final String script, f
try {
result = SshHelper.sshExecute(routerIP, DEFAULT_DOMR_SSHPORT,
"root", getSystemVMKeyFile(), null, "/opt/cloud/bin/" + script + " " + args,
- 60000, 60000, timeout * 1000);
+ 60000, 60000, (int)timeout.getMillis());
--- End diff --
Please consider defining an override of the ``SshHelper.sshExecute`` method
that accepts a ``Duration`` in order to encapsulate this conversion. We should
also consider deprecating the version that accepts ``int``.
> The router script times out resulting in failure of deployment
> --------------------------------------------------------------
>
> Key: CLOUDSTACK-9503
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9503
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
> Affects Versions: 4.9.0
> Environment: KVM, Xen
> Reporter: Abhinandan Prateek
> Assignee: Abhinandan Prateek
> Fix For: 4.9.1.0
>
>
> When starting the virtual router in a shared network in advance zone the
> scripts on router time out. This happen as there are several sub-commands
> that are consolidated in a single command. The default timeout of 2 minutes
> is short.
> 2016-09-09 00:06:25,016 ERROR [c.c.n.r.VirtualNetworkApplianceManagerImpl]
> (Work-Job-Executor-110:ctx-e8089ec7 job-5135/job-5137 ctx-c3a8da18)
> (logid:8aedea66) process hasn't exited
> 2016-09-09 00:06:25,016 WARN [c.c.n.r.VirtualNetworkApplianceManagerImpl]
> (Work-Job-Executor-110:ctx-e8089ec7 job-5135/job-5137 ctx-c3a8da18)
> (logid:8aedea66) Command: com.cloud.agent.api.Command failed while starting
> virtual router
> 2016-09-09 00:06:25,016 INFO [c.c.v.VirtualMachineManagerImpl]
> (Work-Job-Executor-110:ctx-e8089ec7 job-5135/job-5137 ctx-c3a8da18)
> (logid:8aedea66) The guru did not like the answers so stopping
> VM[DomainRouter|r-3445-VM]
> —
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
