[
https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289305#comment-15289305
]
ASF GitHub Bot commented on CLOUDSTACK-8562:
--------------------------------------------
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-220090191
@swill Travis and your CI are passing with this feature during which a data
center is deployed and all sorts of APIs are called so it's likely an env issue
specific for @anshul1886. We've put a lot of testing effort on this including
various upgrade scenarios, and have seen huge amount of effort on code review
so it is not needed to revert the feature; though if there is a valid bug it
ought to be fixed and that's what freeze is about -- fixing bugs.
Here what I'm speculating where it is failing:
Developer sets up CloudStack with a db schema prior to when RBAC was
merged. Then, the developer rebuilds CloudStack but does not redeploy a
fresh/clean db, and commands.properties.in is removed so his static-checker
won't work. The root admin with role_id=1 is by default allowed all APIs in the
dynamic checker so the feature ensures that root-admin is never locked out of
the system. The developers ought to cleanly rebuild CloudStack and re-deploy a
fresh db after a rebase in their feature branch or on master.
> User Definable Roles
> --------------------
>
> Key: CLOUDSTACK-8562
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Reporter: Paul Angus
> Assignee: Rohit Yadav
>
> Static command.properties moved to database and made user definable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
