[ https://issues.apache.org/jira/browse/CLOUDSTACK-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256932#comment-15256932 ]
ASF subversion and git services commented on CLOUDSTACK-9352: ------------------------------------------------------------- Commit a6bae2b9c200cff725fbdabddab6c69a94811561 in cloudstack's branch refs/heads/master from [~williamstev...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a6bae2b ] Merge pull request #1498 from GabrielBrascher/lrg-cs-hackday-038 CLOUDSTACK-9352: Test fails in Widows as the file separator "/" is different from "\"**Problem:** File separator in windows ("\") is different from the expected in the test ("/"); thus, the test *com.cloud.utils.SwiftUtilTest.testSplitSwiftPath()* will fail in Windows systems. The problem is that the input of the test is "*container/object*" but the tested method uses the *File.separator* (that depends from the OS), in windows systems the tested method (*com.cloud.utils.SwiftUtil.splitSwiftPath(String)*) looks for a "\", as the string does not contain "\" it returns an empty string and consequently results in a test failure. **Solution:** Create a string `String input = "container" + File.separator + "object";`, with that the test will validate the tested method verifying if the method splits the string around matches of the given regular expression (in this case *File.separator*). *JIRA link: https://issues.apache.org/jira/browse/CLOUDSTACK-9352* * pr/1498: Test fails in Widows as the file separator "/" is different from "\" Signed-off-by: Will Stevens <williamstev...@gmail.com> > Test fails in Widows as the file separator "/" is different from "\" > -------------------------------------------------------------------- > > Key: CLOUDSTACK-9352 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9352 > Project: CloudStack > Issue Type: Test > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Gabriel Beims Bräscher > Priority: Minor > > Test com.cloud.utils.SwiftUtilTest.testSplitSwiftPath() fails in Widows as > the file separator "/" is different from "\" > Problem: > File separator in windows ("\") is different from the expected in the test > ("/"); thus, the test com.cloud.utils.SwiftUtilTest.testSplitSwiftPath() will > fail in Windows systems. > The problem is that the input of the test is "container/object" but the > tested method uses the File.separator (that depends on from the OS), in the > windows the tested method (com.cloud.utils.SwiftUtil.splitSwiftPath(String)) > looks for a "\", as the string does not contain "\" it returns an empty > string and consequently results in a test failure. > Solution: > Create a string String input = "container" + File.separator + "object"; > (before it was String input = "container/object";); thus, independent of the > OS, the test will validate the tested method in a manner that the file > separator does not disturb the result; -- This message was sent by Atlassian JIRA (v6.3.4#6332)