[ https://issues.apache.org/jira/browse/CLOUDSTACK-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254064#comment-15254064 ]
ASF GitHub Bot commented on CLOUDSTACK-6975: -------------------------------------------- GitHub user dsclose opened a pull request: https://github.com/apache/cloudstack/pull/1514 CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR Rebase of PR #1509 against the 4.7 branch as requested by @swill One LGTM from @ustcweizhou carried from previous PR. Previous PR will be closed. Description from PR #1509: CLOUDSTACK-6975 refers to service monitoring bringing up dnsmasq but this is no-longer accurate, as service monitoring is not active on the post-4.6 routers. These routers still suffer an essentially identical issue, however, because "dnsmasq needs to be restarted each time configure.py is called in order to avoid lease problems." As such, dnsmasq is still running on backup RvRs, causing the issues described in CLOUDSTACK-6975. This PR is based on a patch submitted by @ustcweizhou. The code now checks the redundant state of the router before restarting dnsmasq. RvR networks without this patch have dnsmasq running on both master and backup routers. RvR networks with this patch have dnsmasq running on only the master router. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dsclose/cloudstack CLOUDSTACK-6975 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1514.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1514 ---- commit cb16ce7e6c8197ae289d105bbf829c68db6d5086 Author: dean.close <dean.cl...@icloudhosting.com> Date: 2016-04-22T14:58:16Z CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant routers. ---- > Service monitoring starts dnsmasq on backup router when using redundant VRs > --------------------------------------------------------------------------- > > Key: CLOUDSTACK-6975 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6975 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Virtual Router > Affects Versions: 4.3.0 > Environment: KVM > Reporter: Magnus Bengtsson > > When using a network offering with redundant routers the default setting of > EnableServiceMonitoring enables monit on the routers. > "network.router.EnableServiceMonitoring service monitoring in router > enable/disable option, default true false" > This causes monit to run dnsmasq on both the Master and Backup router. When > the backup router assigns dhcp to clients, password and userdata retrieval > from that node fails since the services are not running on the backup router. -- This message was sent by Atlassian JIRA (v6.3.4#6332)