[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103747#comment-15103747
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9231:
--------------------------------------------

Github user cristofolini commented on the pull request:

    https://github.com/apache/cloudstack/pull/1336#issuecomment-172333464
  
    Fix looks simple enough. Code LGTM. Although I would usually suggest adding 
a javadoc the new `MigrateWithStorageCommand` method you've created, this just 
changes the existing method (which looks clear enough to me already) to use 
Lists instead of maps, so I'll leave that decision up to you @nitin-maharana.


> Root volume migration from one primary to another primary storage within the 
> same cluster is failing
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9231
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9231
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Nitin Kumar Maharana
>
> EXPECTED BEHAVIOR 
> ===================
> Root Volume migration within cluster should work.
> ACTUAL BEHAVIOR 
> ================
> Root volume migration within cluster failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to