[
https://issues.apache.org/jira/browse/CLOUDSTACK-9105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041955#comment-15041955
]
ASF GitHub Bot commented on CLOUDSTACK-9105:
--------------------------------------------
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1167#issuecomment-162047910
Example logs from this branch:
```
2015-12-04 18:37:14,864 DEBUG [c.c.s.StatsCollector]
(StatsCollector-2:ctx-601c739d) (logid:52f7b0de) VmStatsCollector is running...
2015-12-04 18:37:15,963 DEBUG [c.c.a.m.AgentManagerImpl]
(AgentManager-Handler-15:null) (logid:) Ping from 2(kvm2)
2015-12-04 18:37:15,964 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl]
(AgentManager-Handler-15:null) (logid:) Process host VM state report from ping
process. host: 2
2015-12-04 18:37:15,968 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl]
(AgentManager-Handler-15:null) (logid:) Process VM state report. host: 2,
number of records in report: 2
2015-12-04 18:37:15,968 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl]
(AgentManager-Handler-15:null) (logid:) VM state report. host: 2, vm id: 63,
power state: PowerOn
2015-12-04 18:37:15,969 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl]
(AgentManager-Handler-15:null) (logid:) VM power state does not change, skip DB
writing. vm id: 63
2015-12-04 18:37:15,969 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl]
(AgentManager-Handler-15:null) (logid:) VM state report. host: 2, vm id: 62,
power state: PowerOn
2015-12-04 18:37:15,969 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl]
(AgentManager-Handler-15:null) (logid:) VM power state does not change, skip DB
writing. vm id: 62
2015-12-04 18:37:15,971 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl]
(AgentManager-Handler-15:null) (logid:) Done with process of VM state report.
host: 2
2015-12-04 18:37:18,355 DEBUG [c.c.a.m.AgentManagerImpl]
(AgentManager-Handler-12:null) (logid:) SeqA 6-2861: Processing Seq 6-2861: {
Cmd , MgmtId: -1, via: 6, Ver: v1, Flags: 11,
[{"com.cloud.agent.api.ConsoleProxyLoadReportCommand":{"_proxyVmId":63,"_loadInfo":"{\n
\"connections\": []\n}","wait":0}}] }
2015-12-04 18:37:18,359 DEBUG [c.c.a.m.AgentManagerImpl]
(AgentManager-Handler-12:null) (logid:) SeqA 6-2861: Sending Seq 6-2861: {
Ans: , MgmtId: 90520732674657, via: 6, Ver: v1, Flags: 100010,
[{"com.cloud.agent.api.AgentControlAnswer":{"result":true,"wait":0}}] }
2015-12-04 18:37:19,582 DEBUG [c.c.a.m.AgentManagerImpl]
(AgentManager-Handler-11:null) (logid:) Ping from 5(s-62-VM)
2015-12-04 18:37:20,637 DEBUG [c.c.a.m.AgentManagerImpl]
(AgentManager-Handler-14:null) (logid:) Ping from 6(v-63-VM)
2015-12-04 18:37:22,051 INFO [o.a.c.f.j.i.AsyncJobManagerImpl]
(AsyncJobMgr-Heartbeat-1:ctx-354e88d7) (logid:910493fb) Begin cleanup expired
async-jobs
2015-12-04 18:37:22,054 INFO [o.a.c.f.j.i.AsyncJobManagerImpl]
(AsyncJobMgr-Heartbeat-1:ctx-354e88d7) (logid:910493fb) End cleanup expired
async-jobs
2015-12-04 18:37:23,386 DEBUG [c.c.a.m.AgentManagerImpl]
(AgentManager-Handler-4:null) (logid:) SeqA 6-2863: Processing Seq 6-2863: {
Cmd , MgmtId: -1, via: 6, Ver: v1, Flags: 11,
[{"com.cloud.agent.api.ConsoleProxyLoadReportCommand":{"_proxyVmId":63,"_loadInfo":"{\n
\"connections\": []\n}","wait":0}}] }
2015-12-04 18:37:23,389 DEBUG [c.c.a.m.AgentManagerImpl]
(AgentManager-Handler-4:null) (logid:) SeqA 6-2863: Sending Seq 6-2863: { Ans:
, MgmtId: 90520732674657, via: 6, Ver: v1, Flags: 100010,
[{"com.cloud.agent.api.AgentControlAnswer":{"result":true,"wait":0}}] }
```
@koushik-das Like it! My only remark is that some lines have an empty
'logid:' which I'd recommend leaving out (shown in log, not in image).
> Logging enhancement: Handle/reference to track API calls end to end in the MS
> logs
> ----------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9105
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9105
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Koushik Das
> Assignee: Koushik Das
> Fix For: 4.7.0
>
>
> Unique reference for each API call, so that it enables easier tracking and
> debugging.
> The reference handle should be propagated all the way down to the resource
> layer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
