[ https://issues.apache.org/jira/browse/CLOUDSTACK-9083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026484#comment-15026484 ]
ASF GitHub Bot commented on CLOUDSTACK-9083: -------------------------------------------- GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1120 [4.5] CLOUDSTACK-9083: Add disk serial to kvm virt xml Adds disk serial ids based on volume uuids to the virt xml. This may be useful for appliances/software that needs some serial ids on the VM disks. This does not impact existing/running VMs, the vm virt xmls will be updates for running VMs the next time they are stopped/started. For testing, disk serial (of debian based systemvm) in the virt xml matched that in /sys/devices/pci0000:00:0000:00:07.0/virtio4/block/vda/serial. We currently don't support scsi-blcok devices for which serial is not supported, for this we've added a DeviceType (LUN) which may be used in future and a check to not add the serial to the xml if disk type is LUN. Refer: https://libvirt.org/formatdomain.html#elementsDisks JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-9083 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack 4.5-cloudstack-9083 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1120.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1120 ---- commit cbb9c4acdf8262dd74d75df1309d46fa6c6102df Author: Rohit Yadav <rohit.ya...@shapeblue.com> Date: 2015-11-25T09:07:40Z CLOUDSTACK-9083: Add disk serial to kvm virt xml Adds disk serial ids based on volume uuids to the virt xml. This may be useful for appliances/software that needs some serial ids on the VM disks. This does not impact existing/running VMs, the vm virt xmls will be updates for running VMs the next time they are stopped/started. For testing, disk serial (of debian based systemvm) in the virt xml matched that in /sys/devices/pci0000:00:0000:00:07.0/virtio4/block/vda/serial. Signed-off-by: Rohit Yadav <rohit.ya...@shapeblue.com> ---- > Add disk serial to vm/libvirt xml in case of KVM > ------------------------------------------------ > > Key: CLOUDSTACK-9083 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9083 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Rohit Yadav > Assignee: Rohit Yadav > Priority: Minor > Fix For: 4.5.3, 4.7.0, 4.6.1 > > > Certain appliances/software fail on KVM as they require disk serials (inside > of the VM). The fix would be to add a disk serial (from volume uuid) in the > generated libvirt xml for all disks except for lun/scsi block type disks > (which we don't support yet, so we can add in a deviceType for now and leave > some comment). -- This message was sent by Atlassian JIRA (v6.3.4#6332)