[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013458#comment-15013458
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9062:
--------------------------------------------

Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1083#discussion_r45335326
  
    --- Diff: 
api/src/org/apache/cloudstack/api/command/admin/storage/AddImageStoreS3CMD.java 
---
    @@ -201,15 +209,15 @@ public int hashCode() {
             result = 31 * result + (secretKey != null ? secretKey.hashCode() : 
0);
             result = 31 * result + (endPoint != null ? endPoint.hashCode() : 
0);
             result = 31 * result + (bucketName != null ? bucketName.hashCode() 
: 0);
    -        result = 31 * result + (httpsFlag != null && httpsFlag == true ? 1 
: 0);
    +        result = 31 * result + (signer != null ? signer.hashCode() : 0);
    --- End diff --
    
    The same here: would be nice to move hashCode() and equals() methods to the 
end of the file.


> Upgrade AWS SDK to latest version.
> ----------------------------------
>
>                 Key: CLOUDSTACK-9062
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9062
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Secondary Storage
>    Affects Versions: 4.6.0
>            Reporter: Boris Schrijver
>            Assignee: Boris Schrijver
>
> Upgrade AWS SDK to latest version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to