[ https://issues.apache.org/jira/browse/CLOUDSTACK-9057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002174#comment-15002174 ]
ASF GitHub Bot commented on CLOUDSTACK-9057: -------------------------------------------- Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1061#issuecomment-156122612 Since this code is only needed if you upgrade to `4.5` not when you hit this code if you upgrade from say `4.4` and jump forward to `4.6`. This code is still needed in the `4.5` branch but not here. We should run an upgrade test to verify. > upgrade to 4.6 requires 4.5 templates > ------------------------------------- > > Key: CLOUDSTACK-9057 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9057 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Affects Versions: 4.4.2 > Reporter: Daan Hoogland > Assignee: Daan Hoogland > Priority: Minor > > the upgrade coe requiring 4.5 system templates can be removed. > There is a ticket somewhere to make the upgrade code more generic. for this > the maps in the method(s) have to be moved to a central location. The update > call can be an API using those maps. this for prosperity, now remove! -- This message was sent by Atlassian JIRA (v6.3.4#6332)