[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996591#comment-14996591
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9043:
--------------------------------------------

Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1043#issuecomment-155079219
  
    LGTM, browsed around in UI in German and Chinese and didn't see Javascript 
errors.
    
    <img width="648" alt="screen shot 2015-11-09 at 15 28 55" 
src="https://cloud.githubusercontent.com/assets/1630096/11036119/cefc118c-86f6-11e5-8a0e-230f7b0761d4.png";>
    
    <img width="743" alt="screen shot 2015-11-09 at 15 27 11" 
src="https://cloud.githubusercontent.com/assets/1630096/11036136/ed0a6822-86f6-11e5-9711-bcb7c43af837.png";>
    
    The only thing we should improve (later on) is this:
    <img width="692" alt="screen shot 2015-11-09 at 15 28 18" 
src="https://cloud.githubusercontent.com/assets/1630096/11036117/c996b454-86f6-11e5-974b-536ac7c53807.png";>
    How do I get back to English? ;-)



> Localization de_DE and zh_CN don't works: Uncaught SyntaxError: Unexpected 
> token ILLEGAL
> ----------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9043
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9043
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: UI
>    Affects Versions: 4.6.0
>            Reporter: Milamber
>            Assignee: Milamber
>              Labels: ui
>             Fix For: 4.6.0
>
>
> Found 2 bugs in German and Chinese localization (characters illegals in 
> javascript)
> Some strings don't localized, only thes keys displays (all strings after the 
> illegal char)
> (Error message in Chrome: Uncaught SyntaxError: Unexpected token ILLEGAL)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to