[
https://issues.apache.org/jira/browse/CLOUDSTACK-8961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981111#comment-14981111
]
ASF GitHub Bot commented on CLOUDSTACK-8961:
--------------------------------------------
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/941#discussion_r43433480
--- Diff: ui/scripts/network.js ---
@@ -4495,99 +4511,11 @@
$('<li>').addClass('psk').html(_l('message.enabled.vpn.ip.sec') + ' ')
.append($('<strong>').html(psk))
)
- ).multiEdit({
- context: args.context,
- noSelect: true,
- fields: {
- 'username': {
- edit: true,
- label: 'label.username'
- },
- 'password': {
- edit: true,
- isPassword: true,
- label: 'label.password'
- },
- 'add-user': {
- addButton: true,
- label: 'label.add.user'
- }
- },
- add: {
- label: 'label.add.user',
- action: function(args) {
- $.ajax({
- url:
createURL('addVpnUser'),
- data:
$.extend(args.data, {
- domainid:
args.context.ipAddresses[0].domainid,
- account:
args.context.ipAddresses[0].account
- }),
- dataType: 'json',
- type: "POST",
- success:
function(data) {
-
args.response.success({
- _custom: {
- jobId:
data.addvpnuserresponse.jobid
- },
- notification: {
- label:
'label.add.vpn.user',
- poll:
pollAsyncJobResult
- }
- });
- },
- error: function(data) {
-
args.response.error(parseXMLHttpResponse(data));
- }
- });
- }
- },
- actions: {
- destroy: {
- label:
'label.action.delete.user',
- action: function(args) {
- $.ajax({
- url:
createURL('removeVpnUser'),
- data: {
- domainid:
args.context.multiRule[0].domainid,
- account:
args.context.multiRule[0].account,
- username:
args.context.multiRule[0].username
- },
- dataType: 'json',
- async: true,
- success:
function(data) {
- var jobID =
data.removevpnuserresponse.jobid;
-
-
args.response.success({
- _custom: {
- jobId:
jobID
- },
-
notification: {
- label:
'label.delete.vpn.user',
- poll:
pollAsyncJobResult
- }
- });
- }
- });
- }
- }
- },
- dataProvider: function(args) {
- $.ajax({
- url:
createURL('listVpnUsers'),
- data: {
- domainid:
args.context.ipAddresses[0].domainid,
- account:
args.context.ipAddresses[0].account
- },
- dataType: 'json',
- async: true,
- success: function(data) {
- args.response.success({
- data:
data.listvpnusersresponse.vpnuser
- });
- }
- });
- }
- });
+ .append(
+ //Note
+ $('<li>').html('Note: VPN
users are now accessed by changing views at the networks tab.')
--- End diff --
Would be better to use a new localization key and put the text in
messages.properties file. Thanks.
> Making the VPN user management more intutive
> --------------------------------------------
>
> Key: CLOUDSTACK-8961
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8961
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Kshitij Kansal
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
