[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14768869#comment-14768869
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8854:
--------------------------------------------

Github user sureshanaparti commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/828#discussion_r39624157
  
    --- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java ---
    @@ -598,6 +601,19 @@ public static void 
setBasicVmConfig(VirtualMachineConfigSpec vmConfig, int cpuCo
             vmConfig.setGuestId(guestOsIdentifier);
         }
     
    +    public static void addUSBController(VirtualMachineConfigSpec 
vmConfigSpec) {
    --- End diff --
    
    @sateesh-chodapuneedi all the prepareXyzDevice() methods in VmwareHelper 
class returns VirtualDevice. So to be consistent, i think it is better to 
return a VirtualDevice when preparing USB controller and this device is added 
to the device config spec same as other devices.


> Apple Mac OS/X VM get created without USB controller in ESXi hypervisors
> ------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8854
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8854
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: VMware
>            Reporter: Suresh Kumar Anaparti
>            Assignee: Suresh Kumar Anaparti
>             Fix For: 4.6.0
>
>
> ISSUE
> ==================
> Apple Mac OS/X VM get created without USB controller. For mouse/keyboard to 
> function in CS Console window VM has to have USB controller. It seems CS 
> doesn't use the same procedure as native vSphere client because natively when 
> OS is specified as OS/X vSphere always adds USB controller to empty VM shell.
> EXPECTED BEHAVIOR
> ==================
> USB device added to VM when created on CS
> ACTUAL BEHAVIOR
> ==================
> No USB device added



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to