[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740886#comment-14740886
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8799:
--------------------------------------------

Github user bvbharatk commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/784#discussion_r39275218
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
    @@ -95,9 +95,25 @@ def get_control_if(self):
                     return ip
             return None
     
    +    def check_if_link_exists(self,dev):
    +        cmd="ip link show dev %s"%dev
    +        result=CsHelper.execute(cmd)
    +        if(len(result)!=0):
    +           return True
    +        else:
    +           return False
    +
    +    def check_if_link_up(self,dev):
    +        cmd="ip link show dev %s | tr '\n' ' ' | cut -d ' ' -f 9"%dev
    --- End diff --
    
    Hi, 
    we have used the subprocess command to find the state of the device in two 
more places. I have created a improvement ticket(CLOUDSTACK-8837) to track 
this. I will work on this later, until then 
    i guess the current changes will do.
    



> fix CsRedundant.py to handle public interfaces and default routes when 
> changing state.
> --------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8799
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8799
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Virtual Router
>    Affects Versions: 4.6.0
>            Reporter: Bharat Kumar
>            Assignee: Bharat Kumar
>            Priority: Blocker
>
> When the Vr changes state to backup we need bring all the public interfaces 
> down. Similarly when it changes state to master we have bring all the public 
> interfaces up and add the default routes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to