[
https://issues.apache.org/jira/browse/CLOUDSTACK-8822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740612#comment-14740612
]
ASF GitHub Bot commented on CLOUDSTACK-8822:
--------------------------------------------
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/805#discussion_r39262559
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -1315,6 +1321,10 @@ protected void doTask(final Task task) throws
Exception {
} catch (final UnsupportedVersionException e) {
s_logger.warn(e.getMessage());
// upgradeAgent(task.getLink(), data,
e.getReason());
+ } catch (final ClassNotFoundException e) {
+ final String message = String.format("Exception
occured when executing taks! Error '%s'", e.getMessage());
--- End diff --
s/taks/task/ (minor issue)
> Replace Runnable by Callable in the com.cloud.utils.nio.Task class.
> -------------------------------------------------------------------
>
> Key: CLOUDSTACK-8822
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8822
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Wilder Rodrigues
> Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>
> The current implementation of the Task abstract class swallows all the
> exceptions - everything extending Throwable - with only a WARN message.
> The best way to do that is by implementing Callable, which returns a value
> and also has a "throws Exception" in the call(0 method signature.
> This work will be structural, changing the hierarchy of Task and also its
> subclasses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
