[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-5651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868056#comment-13868056
 ] 

ASF subversion and git services commented on CLOUDSTACK-5651:
-------------------------------------------------------------

Commit 7053c222f989d2a9d1ae0ea8237a08e328fcb7c1 in branch refs/heads/master 
from [~bharat.kumar]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7053c22 ]

CLOUDSTACK-5651 deployVm: customparameters param name has to be changed

Signed-off-by: Alena Prokharchyk <[email protected]>

Conflicts:
        
api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java
        
api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java
        api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
        api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java
        api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java
        server/src/com/cloud/server/ManagementServerImpl.java
        server/src/com/cloud/vm/UserVmManagerImpl.java


> deployVm: customparameters param name has to be changed
> -------------------------------------------------------
>
>                 Key: CLOUDSTACK-5651
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5651
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.3.0
>            Reporter: Alena Prokharchyk
>            Assignee: Bharat Kumar
>            Priority: Critical
>             Fix For: 4.3.0
>
>
> deployVm API got a new param in 4.3 -“customparameters”. The description of 
> the parameter is very vague and generic “used to specify the custom 
> parameters”.
> Is it just the metadata in form of value/key pairs? If so, please change the 
> name to “details” - the generic name used when specify key/value metadata in 
> other API commands. 
> Also you need to save this information in the “user_vm_details” table, and 
> return it in the UserVmResponse, “details” map parameter. I don’t see “custom 
> parameters” key map being returned anywhere in the UserVmResponse. Its very 
> confusing, because whatever is passed to the Create/Update call, should be 
> returned in the response as well.
> It all has to be fixed in 4.3 branch.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to