[ 
https://issues.apache.org/jira/browse/CAMEL-15943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248890#comment-17248890
 ] 

Aurélien Pupier edited comment on CAMEL-15943 at 12/14/20, 10:35 AM:
---------------------------------------------------------------------

{quote}flatten the properties and have an option to determine where they 
applies so if they are marked as mandatory, it is explicit that setting at 
component or endpoint level is equivalent{quote}

this requires that it is a property with the same name.
it doesn't cover the case for instance of having "homeAddress" and 
"officeAddress" and requires to have one of the 2.

But I don't know if it happens currently or if we want to have it happening. If 
it doesn't, it sounds simpler.

The downside of this approach is that I think it will require to radically 
change the catalog and it will break the backward-compatibility.

{quote}I'm curious how the validation can be performed ad design time  given 
that the property may exists only at runtime{quote}
The validation currently expects all required properties to be defined at 
design time. It is not specific to "oneOf".
This is an assumption that was good enough for several years but it is possible 
that it is no more reliable enough and deactivate this kind of validation in 
Camel catalog and Eclipse Fuse Tooling (and not implement it for Camel Kafka 
Connector in Camel Language Server)


was (Author: apupier):
{quote}flatten the properties and have an option to determine where they 
applies so if they are marked as mandatory, it is explicit that setting at 
component or endpoint level is equivalent{quote}

this requires that it is a property with the same name.
it doesn't cover the case for instance of having "homeAddress" and 
"officeAddress" and requires to have one of the 2.

But I don't know if it happens currently or if we want to have it happening. If 
it doesn't, it sounds simpler.

The downside of this approach is that I think it will require to radically 
change the catalog and it will break the backward-compatibility.

{quote}I'm curious how the validation can be performed ad design time  given 
that the property may exists only at runtime{quote}
The validation currently expects all required properties to be defined at 
design time. It is not specific to "oneOf".
This is an assumption that was good enough for several years but it is possible 
that it is no more reliable enough and deactivate this kind of validation in 
Camel catalog (and not implement it for Camel Kafka Connector in Camel Language 
Server)

> Support "oneOf" requirements of attributes inside the Catalog
> -------------------------------------------------------------
>
>                 Key: CAMEL-15943
>                 URL: https://issues.apache.org/jira/browse/CAMEL-15943
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-catalog
>    Affects Versions: 3.7.0
>            Reporter: Aurélien Pupier
>            Priority: Minor
>
> There are some components that allow to configure an option on either 
> component or endpoint that would be required.
> For instance the "operation" parameter for aws2-iam



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to