[ 
https://issues.apache.org/jira/browse/CAMEL-11646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136632#comment-16136632
 ] 

Gary Brown commented on CAMEL-11646:
------------------------------------

When originally doing the work I used the active span approach in OT, but 
because the default impl uses thread local there were problems propagating the 
context across threads.

The current approach is simpler because it piggybacks the trace context (span 
stack) with the exchange itself. However I can see there are times when other 
functionality may be relying on knowledge of the current span, outside the 
camel/exchange.

However before looking at changing anything, would prefer to wait until 
https://github.com/opentracing/opentracing-java/pull/166 is resolved, as this 
will have an impact on this mechanism.

> Upgrade brave to allow simple MDC logging
> -----------------------------------------
>
>                 Key: CAMEL-11646
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11646
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-opentracing
>    Affects Versions: 2.19.1
>            Reporter: Radek Mensik
>
> It would be nice if spans are logged as we know it from spring-sleuth. 
> Simplest could be usage of brave-context-slf4j 
> https://github.com/openzipkin/brave/tree/master/context/slf4j.
> Unfortunately this requires higher version of brave. I tried to make it work 
> with 2.20.0-SNAPSHOT but no luck..



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to