[
https://issues.apache.org/jira/browse/CAMEL-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051659#comment-16051659
]
ASF GitHub Bot commented on CAMEL-11244:
----------------------------------------
GitHub user tlehoux opened a pull request:
https://github.com/apache/camel/pull/1770
CAMEL-11244: camel-hazelcast: use string/enum instead of numeric operation
type
I've kept operations current names in order to have backward compatibility
especially with Spring/XML DSL. However, entries in HazelcastConstants have
been declared as deprecated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tlehoux/camel master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1770.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1770
----
commit 09aa0bd6ffc42c394f7bf4fa34f304a7665a0cd2
Author: Thomas Lehoux <[email protected]>
Date: 2017-06-16T09:16:32Z
CAMEL-11244: camel-hazelcast: use string/enum instead of numeric operation
type
----
> camel-hazelcast: use string/enum instead of numeric operation type
> ------------------------------------------------------------------
>
> Key: CAMEL-11244
> URL: https://issues.apache.org/jira/browse/CAMEL-11244
> Project: Camel
> Issue Type: Improvement
> Components: camel-hazelcast
> Reporter: Luca Burgazzoli
> Fix For: 2.20.0
>
>
> camel-hazelcast defines the operation using an integer but you can also use a
> string when configuring the endpoint so it is a mix of styles that we should
> avoid so it would be nice if we use enum/string everywhere.
> {code:java}
> HazelcastOperation {
> PUT,
> ...;
> }
> HazelcastDefaultEndpoint {
> @UriParam
> private HazelcastOperation defaultOperation;
> }
> {code}
> This difference of types adds some additional maintenance work as one has to
> maintain:
> -
> [maping|https://github.com/apache/camel/blob/master/components/camel-hazelcast/src/main/java/org/apache/camel/component/hazelcast/HazelcastComponentHelper.java#L27]
> -
> [constants|https://github.com/apache/camel/blob/master/components/camel-hazelcast/src/main/java/org/apache/camel/component/hazelcast/HazelcastConstants.java#L60-L104]
> - [operation
> enums|https://github.com/apache/camel/blob/master/components/camel-hazelcast/src/main/java/org/apache/camel/component/hazelcast/HazelcastDefaultEndpoint.java#L44-L46]
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
