Arno Noordover created CAMEL-9954:
-------------------------------------
Summary: FormatFactory should be real Factory-pattern
Key: CAMEL-9954
URL: https://issues.apache.org/jira/browse/CAMEL-9954
Project: Camel
Issue Type: Improvement
Components: camel-bindy
Reporter: Arno Noordover
Priority: Minor
The class org.apache.camel.dataformat.bindy.FormatFactory is a utility class
which supports a factory-pattern.
According to the factory-pattern this should not be a utility-class but it
should be a class that can be instantiated.
This class should implement an interface or extend an abstract class.
Maybe we should make a factory per Format and choose amongst the following
solutions:
* let each formatter answer the question about being able to format for certain
formating-options (based on type and optionally the pattern for all "numeric"
format factories);
* put all formatters in a hashmap with the type as a key.
With this last solution all the "numeric" format factory should decide which
format to return (e.g. BytePatternFormat or ByteFormat based on the pattern
being empty or not)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)