[ 
https://issues.apache.org/jira/browse/CAMEL-27277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18148023#comment-18148023
 ] 

Guillaume Nodet commented on CAMEL-27277:
-----------------------------------------

This issue is being investigated by a coding agent (on behalf of gnodet).

Root cause identified: The test SftpSimpleProduceDisconnectIT has a race 
condition where the DefaultProducerTemplate reuses a cached producer with a 
stale JSch session after server restart. The sendNoop() check can falsely 
succeed because the TCP RST from server shutdown may not have been received 
yet, causing a Broken pipe on the subsequent channel operation.

Proposed fix: Add disconnect=true to the SFTP URI in the test so the producer 
disconnects after each send, forcing a fresh connection after the server 
restart. This eliminates the stale-connection race entirely.

_Note: This comment was generated by an AI coding agent and requires manual 
verification._

> Fix flaky test SftpSimpleProduceDisconnectIT
> --------------------------------------------
>
>                 Key: CAMEL-27277
>                 URL: https://issues.apache.org/jira/browse/CAMEL-27277
>             Project: Camel
>          Issue Type: Test
>          Components: camel-sftp
>    Affects Versions: 4.24.0
>            Reporter: Aurélien Pupier
>            Assignee: Guillaume Nodet
>            Priority: Major
>
> it started to be flaky 2 days ago.
> 0 flaky and 0 failed tests in the 88 days prior that
> [in last 2 days it was flaky 3 times and failed 1 
> time|https://develocity.apache.org/scans/tests?search.relativeStartTime=P90D&search.rootProjectNames=camel&search.tags=main&search.timeZoneId=Europe%2FParis&tests.container=org.apache.camel.component.file.remote.sftp.integration.SftpSimpleProduceDisconnectIT&tests.test=testSftpSimpleProduce]
> {noformat}
> org.apache.camel.CamelExecutionException: Exception occurred during execution 
> on the exchange: Exchange[]     
>       at 
> org.apache.camel.CamelExecutionException.wrapCamelExecutionException(CamelExecutionException.java:60)
>         
>       at 
> org.apache.camel.support.ExchangeHelper.extractResultBody(ExchangeHelper.java:737)
>    
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.extractResultBody(DefaultProducerTemplate.java:600)
>      
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.extractResultBody(DefaultProducerTemplate.java:596)
>      
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.sendBodyAndHeader(DefaultProducerTemplate.java:226)
>      
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.sendBodyAndHeader(DefaultProducerTemplate.java:218)
>      
>       at 
> org.apache.camel.component.file.remote.sftp.integration.SftpSimpleProduceDisconnectIT.testSftpSimpleProduce(SftpSimpleProduceDisconnectIT.java:46)
>    
> Caused by: 
> org.apache.camel.component.file.GenericFileOperationFailedException: Cannot 
> change directory to: target: SSH_FX_FAILURE: java.net.SocketException: Broken 
> pipe     
>       at 
> org.apache.camel.component.file.remote.SftpOperations.doChangeDirectory(SftpOperations.java:1066)
>     
>       at 
> org.apache.camel.component.file.remote.SftpOperations.changeCurrentDirectory(SftpOperations.java:1040)
>        
>       at 
> org.apache.camel.component.file.remote.SftpOperations.storeFile(SftpOperations.java:1467)
>     
>       at 
> org.apache.camel.component.file.GenericFileProducer.writeFile(GenericFileProducer.java:490)
>   
>       at 
> org.apache.camel.component.file.GenericFileProducer.processExchange(GenericFileProducer.java:182)
>     
>       at 
> org.apache.camel.component.file.remote.RemoteFileProducer.doProcess(RemoteFileProducer.java:65)
>       
>       at 
> org.apache.camel.component.file.GenericFileProducer.process(GenericFileProducer.java:75)
>      
>       at 
> org.apache.camel.support.cache.DefaultProducerCache$SyncSend.process(DefaultProducerCache.java:381)
>   
>       at 
> org.apache.camel.impl.engine.SharedCamelInternalProcessor.processNonTransacted(SharedCamelInternalProcessor.java:160)
>         
>       at 
> org.apache.camel.impl.engine.SharedCamelInternalProcessor.process(SharedCamelInternalProcessor.java:137)
>      
>       at 
> org.apache.camel.impl.engine.SharedCamelInternalProcessor$1.process(SharedCamelInternalProcessor.java:89)
>     
>       at 
> org.apache.camel.impl.engine.DefaultAsyncProcessorAwaitManager.process(DefaultAsyncProcessorAwaitManager.java:84)
>     
>       at 
> org.apache.camel.impl.engine.SharedCamelInternalProcessor.process(SharedCamelInternalProcessor.java:86)
>       
>       at 
> org.apache.camel.support.cache.DefaultProducerCache.send(DefaultProducerCache.java:180)
>       
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.send(DefaultProducerTemplate.java:181)
>   
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.send(DefaultProducerTemplate.java:177)
>   
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.send(DefaultProducerTemplate.java:158)
>   
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.sendBodyAndHeader(DefaultProducerTemplate.java:224)
>      
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.sendBodyAndHeader(DefaultProducerTemplate.java:218)
>      
>       at 
> org.apache.camel.component.file.remote.sftp.integration.SftpSimpleProduceDisconnectIT.testSftpSimpleProduce(SftpSimpleProduceDisconnectIT.java:46)
>    
> Caused by: com.jcraft.jsch.SftpException: java.net.SocketException: Broken 
> pipe       
>       at com.jcraft.jsch.ChannelSftp.cd(ChannelSftp.java:344) 
>       at 
> org.apache.camel.component.file.remote.SftpOperations.doChangeDirectory(SftpOperations.java:1053)
>     
>       at 
> org.apache.camel.component.file.remote.SftpOperations.changeCurrentDirectory(SftpOperations.java:1040)
>        
>       at 
> org.apache.camel.component.file.remote.SftpOperations.storeFile(SftpOperations.java:1467)
>     
>       at 
> org.apache.camel.component.file.GenericFileProducer.writeFile(GenericFileProducer.java:490)
>   
>       at 
> org.apache.camel.component.file.GenericFileProducer.processExchange(GenericFileProducer.java:182)
>     
>       at 
> org.apache.camel.component.file.remote.RemoteFileProducer.doProcess(RemoteFileProducer.java:65)
>       
>       at 
> org.apache.camel.component.file.GenericFileProducer.process(GenericFileProducer.java:75)
>      
>       at 
> org.apache.camel.support.cache.DefaultProducerCache$SyncSend.process(DefaultProducerCache.java:381)
>   
>       at 
> org.apache.camel.impl.engine.SharedCamelInternalProcessor.processNonTransacted(SharedCamelInternalProcessor.java:160)
>         
>       at 
> org.apache.camel.impl.engine.SharedCamelInternalProcessor.process(SharedCamelInternalProcessor.java:137)
>      
>       at 
> org.apache.camel.impl.engine.SharedCamelInternalProcessor$1.process(SharedCamelInternalProcessor.java:89)
>     
>       at 
> org.apache.camel.impl.engine.DefaultAsyncProcessorAwaitManager.process(DefaultAsyncProcessorAwaitManager.java:84)
>     
>       at 
> org.apache.camel.impl.engine.SharedCamelInternalProcessor.process(SharedCamelInternalProcessor.java:86)
>       
>       at 
> org.apache.camel.support.cache.DefaultProducerCache.send(DefaultProducerCache.java:180)
>       
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.send(DefaultProducerTemplate.java:181)
>   
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.send(DefaultProducerTemplate.java:177)
>   
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.send(DefaultProducerTemplate.java:158)
>   
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.sendBodyAndHeader(DefaultProducerTemplate.java:224)
>      
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.sendBodyAndHeader(DefaultProducerTemplate.java:218)
>      
>       at 
> org.apache.camel.component.file.remote.sftp.integration.SftpSimpleProduceDisconnectIT.testSftpSimpleProduce(SftpSimpleProduceDisconnectIT.java:46)
>    
> Caused by: java.net.SocketException: Broken pipe      
>       at sun.nio.ch.SocketDispatcher.write0(Native Method)    
>               •••
>       at 
> org.apache.camel.component.file.remote.SftpOperations.doChangeDirectory(SftpOperations.java:1053)
>     
>       at 
> org.apache.camel.component.file.remote.SftpOperations.changeCurrentDirectory(SftpOperations.java:1040)
>        
>       at 
> org.apache.camel.component.file.remote.SftpOperations.storeFile(SftpOperations.java:1467)
>     
>       at 
> org.apache.camel.component.file.GenericFileProducer.writeFile(GenericFileProducer.java:490)
>   
>       at 
> org.apache.camel.component.file.GenericFileProducer.processExchange(GenericFileProducer.java:182)
>     
>       at 
> org.apache.camel.component.file.remote.RemoteFileProducer.doProcess(RemoteFileProducer.java:65)
>       
>       at 
> org.apache.camel.component.file.GenericFileProducer.process(GenericFileProducer.java:75)
>      
>       at 
> org.apache.camel.support.cache.DefaultProducerCache$SyncSend.process(DefaultProducerCache.java:381)
>   
>       at 
> org.apache.camel.impl.engine.SharedCamelInternalProcessor.processNonTransacted(SharedCamelInternalProcessor.java:160)
>         
>       at 
> org.apache.camel.impl.engine.SharedCamelInternalProcessor.process(SharedCamelInternalProcessor.java:137)
>      
>       at 
> org.apache.camel.impl.engine.SharedCamelInternalProcessor$1.process(SharedCamelInternalProcessor.java:89)
>     
>       at 
> org.apache.camel.impl.engine.DefaultAsyncProcessorAwaitManager.process(DefaultAsyncProcessorAwaitManager.java:84)
>     
>       at 
> org.apache.camel.impl.engine.SharedCamelInternalProcessor.process(SharedCamelInternalProcessor.java:86)
>       
>       at 
> org.apache.camel.support.cache.DefaultProducerCache.send(DefaultProducerCache.java:180)
>       
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.send(DefaultProducerTemplate.java:181)
>   
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.send(DefaultProducerTemplate.java:177)
>   
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.send(DefaultProducerTemplate.java:158)
>   
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.sendBodyAndHeader(DefaultProducerTemplate.java:224)
>      
>       at 
> org.apache.camel.impl.engine.DefaultProducerTemplate.sendBodyAndHeader(DefaultProducerTemplate.java:218)
>      
>       at 
> org.apache.camel.component.file.remote.sftp.integration.SftpSimpleProduceDisconnectIT.testSftpSimpleProduce(SftpSimpleProduceDisconnectIT.java:46)
>    
> {noformat}



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to