[
https://issues.apache.org/jira/browse/CAMEL-24962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118441#comment-18118441
]
Claus Ibsen commented on CAMEL-24962:
-------------------------------------
All sub-tasks are fixed in one PR: https://github.com/apache/camel/pull/26806
(one commit per sub-task).
_Claude Code on behalf of davsclaus_
> simple language - review findings: bugs and tidy-ups
> ----------------------------------------------------
>
> Key: CAMEL-24962
> URL: https://issues.apache.org/jira/browse/CAMEL-24962
> Project: Camel
> Issue Type: Task
> Components: camel-core
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Major
> Fix For: 4.23.0
>
>
> A deep review of the simple language source
> (core/camel-core-languages/.../language/simple) found around 45 real bugs
> plus a set of tidy-ups. The code is old and hand-written; most bugs predate
> the recent work (the CAMEL-22894 factory split did not introduce dispatch
> regressions). One is a fresh regression from CAMEL-24921.
> The findings are grouped into sub-tasks:
> * regression from CAMEL-24921 (fix first)
> * tokenizer and predicate parser
> * init blocks
> * operators and numeric literals
> * function argument parsing
> * string, math, date and file functions
> * collection and misc functions
> * catalog, docs and syntax hints (SimpleConstants feeds simple.json and the
> MCP/TUI tooling)
> * internal tidy-ups (dead code, duplication, per-exchange work)
> Checked and fine: expression vs predicate caches do not collide, && and ||
> short-circuit, no thread-safety issue in static token tables, no factory
> shadows another after the split.
> _Claude Code on behalf of davsclaus (found by an AI review of the simple
> language source; each item marked (verified) was reproduced on main at
> c3ef718de2e8)_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)